[PATCH] Refactor VariantMatcher to use an interface underneath.

Manuel Klimek klimek at google.com
Thu Aug 22 02:57:28 PDT 2013


  Hm, I feel like there should be more simplification possible, but I'm fine with looking at that after the next patch (or as part of the next patch). So lg.


================
Comment at: include/clang/ASTMatchers/Dynamic/VariantValue.h:56
@@ +55,3 @@
+  ///
+  /// It follows a similar interface than VariantMatcher itself.
+  class Payload {
----------------
isn't it similar ... as?

================
Comment at: include/clang/ASTMatchers/Dynamic/VariantValue.h:57
@@ +56,3 @@
+  /// It follows a similar interface than VariantMatcher itself.
+  class Payload {
+  public:
----------------
It looks like Payload basically carries around the type information. Thus, I'd call it TypeInfo?


http://llvm-reviews.chandlerc.com/D1446

BRANCH
  variant_matcher

ARCANIST PROJECT
  clang



More information about the cfe-commits mailing list