r188934 - Removed unnecessary asserts.
Aaron Ballman
aaron at aaronballman.com
Wed Aug 21 14:38:46 PDT 2013
Author: aaronballman
Date: Wed Aug 21 16:38:46 2013
New Revision: 188934
URL: http://llvm.org/viewvc/llvm-project?rev=188934&view=rev
Log:
Removed unnecessary asserts.
Patch thanks to Christian Wailes!
Modified:
cfe/trunk/lib/Sema/SemaDeclAttr.cpp
Modified: cfe/trunk/lib/Sema/SemaDeclAttr.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaDeclAttr.cpp?rev=188934&r1=188933&r2=188934&view=diff
==============================================================================
--- cfe/trunk/lib/Sema/SemaDeclAttr.cpp (original)
+++ cfe/trunk/lib/Sema/SemaDeclAttr.cpp Wed Aug 21 16:38:46 2013
@@ -497,8 +497,6 @@ enum ThreadAttributeDeclKind {
static bool checkGuardedVarAttrCommon(Sema &S, Decl *D,
const AttributeList &Attr) {
- assert(!Attr.isInvalid());
-
if (!checkAttributeNumArgs(S, Attr, 0))
return false;
@@ -537,8 +535,6 @@ static void handlePtGuardedVarAttr(Sema
static bool checkGuardedByAttrCommon(Sema &S, Decl *D,
const AttributeList &Attr,
Expr* &Arg) {
- assert(!Attr.isInvalid());
-
if (!checkAttributeNumArgs(S, Attr, 1))
return false;
@@ -584,8 +580,6 @@ static void handlePtGuardedByAttr(Sema &
static bool checkLockableAttrCommon(Sema &S, Decl *D,
const AttributeList &Attr) {
- assert(!Attr.isInvalid());
-
if (!checkAttributeNumArgs(S, Attr, 0))
return false;
@@ -618,8 +612,6 @@ static void handleScopedLockableAttr(Sem
static void handleNoThreadSafetyAnalysis(Sema &S, Decl *D,
const AttributeList &Attr) {
- assert(!Attr.isInvalid());
-
if (!checkAttributeNumArgs(S, Attr, 0))
return;
@@ -635,8 +627,6 @@ static void handleNoThreadSafetyAnalysis
static void handleNoSanitizeAddressAttr(Sema &S, Decl *D,
const AttributeList &Attr) {
- assert(!Attr.isInvalid());
-
if (!checkAttributeNumArgs(S, Attr, 0))
return;
@@ -653,8 +643,6 @@ static void handleNoSanitizeAddressAttr(
static void handleNoSanitizeMemory(Sema &S, Decl *D,
const AttributeList &Attr) {
- assert(!Attr.isInvalid());
-
if (!checkAttributeNumArgs(S, Attr, 0))
return;
@@ -670,8 +658,6 @@ static void handleNoSanitizeMemory(Sema
static void handleNoSanitizeThread(Sema &S, Decl *D,
const AttributeList &Attr) {
- assert(!Attr.isInvalid());
-
if (!checkAttributeNumArgs(S, Attr, 0))
return;
@@ -688,8 +674,6 @@ static void handleNoSanitizeThread(Sema
static bool checkAcquireOrderAttrCommon(Sema &S, Decl *D,
const AttributeList &Attr,
SmallVectorImpl<Expr *> &Args) {
- assert(!Attr.isInvalid());
-
if (!checkAttributeAtLeastNumArgs(S, Attr, 1))
return false;
@@ -749,8 +733,6 @@ static void handleAcquiredBeforeAttr(Sem
static bool checkLockFunAttrCommon(Sema &S, Decl *D,
const AttributeList &Attr,
SmallVectorImpl<Expr *> &Args) {
- assert(!Attr.isInvalid());
-
// zero or more arguments ok
// check that the attribute is applied to a function
@@ -824,8 +806,6 @@ static void handleAssertExclusiveLockAtt
static bool checkTryLockFunAttrCommon(Sema &S, Decl *D,
const AttributeList &Attr,
SmallVectorImpl<Expr *> &Args) {
- assert(!Attr.isInvalid());
-
if (!checkAttributeAtLeastNumArgs(S, Attr, 1))
return false;
@@ -878,8 +858,6 @@ static void handleExclusiveTrylockFuncti
static bool checkLocksRequiredCommon(Sema &S, Decl *D,
const AttributeList &Attr,
SmallVectorImpl<Expr *> &Args) {
- assert(!Attr.isInvalid());
-
if (!checkAttributeAtLeastNumArgs(S, Attr, 1))
return false;
@@ -925,8 +903,6 @@ static void handleSharedLocksRequiredAtt
static void handleUnlockFunAttr(Sema &S, Decl *D,
const AttributeList &Attr) {
- assert(!Attr.isInvalid());
-
// zero or more arguments ok
if (!isa<FunctionDecl>(D) && !isa<FunctionTemplateDecl>(D)) {
@@ -948,8 +924,6 @@ static void handleUnlockFunAttr(Sema &S,
static void handleLockReturnedAttr(Sema &S, Decl *D,
const AttributeList &Attr) {
- assert(!Attr.isInvalid());
-
if (!checkAttributeNumArgs(S, Attr, 1))
return;
@@ -973,8 +947,6 @@ static void handleLockReturnedAttr(Sema
static void handleLocksExcludedAttr(Sema &S, Decl *D,
const AttributeList &Attr) {
- assert(!Attr.isInvalid());
-
if (!checkAttributeAtLeastNumArgs(S, Attr, 1))
return;
@@ -999,7 +971,6 @@ static void handleLocksExcludedAttr(Sema
static void handleConsumesAttr(Sema &S, Decl *D,
const AttributeList &Attr) {
- assert(!Attr.isInvalid());
if (!checkAttributeNumArgs(S, Attr, 0)) return;
if (!(isa<CXXMethodDecl>(D) || isa<CXXConstructorDecl>(D))) {
@@ -1015,7 +986,6 @@ static void handleConsumesAttr(Sema &S,
static void handleCallableWhenUnconsumedAttr(Sema &S, Decl *D,
const AttributeList &Attr) {
- assert(!Attr.isInvalid());
if (!checkAttributeNumArgs(S, Attr, 0)) return;
if (!isa<CXXMethodDecl>(D)) {
@@ -1031,7 +1001,6 @@ static void handleCallableWhenUnconsumed
static void handleTestsConsumedAttr(Sema &S, Decl *D,
const AttributeList &Attr) {
- assert(!Attr.isInvalid());
if (!checkAttributeNumArgs(S, Attr, 0)) return;
if (!isa<CXXMethodDecl>(D)) {
@@ -1047,7 +1016,6 @@ static void handleTestsConsumedAttr(Sema
static void handleTestsUnconsumedAttr(Sema &S, Decl *D,
const AttributeList &Attr) {
- assert(!Attr.isInvalid());
if (!checkAttributeNumArgs(S, Attr, 0)) return;
if (!isa<CXXMethodDecl>(D)) {
@@ -1714,7 +1682,6 @@ static void handleMayAliasAttr(Sema &S,
}
static void handleNoCommonAttr(Sema &S, Decl *D, const AttributeList &Attr) {
- assert(!Attr.isInvalid());
if (isa<VarDecl>(D))
D->addAttr(::new (S.Context)
NoCommonAttr(Attr.getRange(), S.Context,
@@ -1725,8 +1692,6 @@ static void handleNoCommonAttr(Sema &S,
}
static void handleCommonAttr(Sema &S, Decl *D, const AttributeList &Attr) {
- assert(!Attr.isInvalid());
-
if (S.LangOpts.CPlusPlus) {
S.Diag(Attr.getLoc(), diag::err_common_not_supported_cplusplus);
return;
@@ -4020,13 +3985,10 @@ static void handleCallConvAttr(Sema &S,
}
static void handleOpenCLKernelAttr(Sema &S, Decl *D, const AttributeList &Attr){
- assert(!Attr.isInvalid());
D->addAttr(::new (S.Context) OpenCLKernelAttr(Attr.getRange(), S.Context));
}
static void handleOpenCLImageAccessAttr(Sema &S, Decl *D, const AttributeList &Attr){
- assert(!Attr.isInvalid());
-
Expr *E = Attr.getArg(0);
llvm::APSInt ArgNum(32);
if (E->isTypeDependent() || E->isValueDependent() ||
More information about the cfe-commits
mailing list