[PATCH] Use lowercase version of argv[0] when determining driver mode

[Reid Kleckner]

On Tue, Aug 20, 2013 at 2:44 PM, Hans Wennborg <hans at chromium.org> wrote:

> On Tue, Aug 20, 2013 at 2:26 PM, Reid Kleckner <rnk at google.com> wrote:
> >>    std::string ProgName(llvm::sys::path::stem(ArgVector[0]));
> >> +  for (size_t i = 0, e = ProgName.length(); i != e; ++i)
> >> +    ProgName[i] = toLowercase(ProgName[i]);
> >
> >
> > This is modern C++, we can't use for loops, what are we, farmers!?
> > std::transform(ProgName.begin(), ProgName.end(), ProgName.begin(),
> > ::toLowerCase);
>
> Sure, I've updated the patch.
>
> > Also, should we do this transform on non-Windows platforms?
>
> Yes, I think we should. Mostly because I don't see any reason not to,
> and the less platform-specific code, the better.
>

OK.  LGTM


> New patch uploaded.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130820/92b71c7d/attachment.html>