r188625 - libclang: cleanup unused includes in public header

Jordan Rose jordan_rose at apple.com
Mon Aug 19 08:34:17 PDT 2013


Since these are now going into .cpp files, is it better form to use the <cstdio> form, like (most of) the rest of Clang does?

Jordan

On Aug 18, 2013, at 0:57 , Dmitri Gribenko <gribozavr at gmail.com> wrote:

> Author: gribozavr
> Date: Sun Aug 18 02:57:43 2013
> New Revision: 188625
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=188625&view=rev
> Log:
> libclang: cleanup unused includes in public header
> 
> Modified:
>    cfe/trunk/include/clang-c/Index.h
>    cfe/trunk/tools/libclang/CXCompilationDatabase.cpp
>    cfe/trunk/tools/libclang/Indexing.cpp
> 
> Modified: cfe/trunk/include/clang-c/Index.h
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang-c/Index.h?rev=188625&r1=188624&r2=188625&view=diff
> ==============================================================================
> --- cfe/trunk/include/clang-c/Index.h (original)
> +++ cfe/trunk/include/clang-c/Index.h Sun Aug 18 02:57:43 2013
> @@ -16,9 +16,7 @@
> #ifndef CLANG_C_INDEX_H
> #define CLANG_C_INDEX_H
> 
> -#include <sys/stat.h>
> #include <time.h>
> -#include <stdio.h>
> 
> #include "clang-c/Platform.h"
> #include "clang-c/CXString.h"
> 
> Modified: cfe/trunk/tools/libclang/CXCompilationDatabase.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/libclang/CXCompilationDatabase.cpp?rev=188625&r1=188624&r2=188625&view=diff
> ==============================================================================
> --- cfe/trunk/tools/libclang/CXCompilationDatabase.cpp (original)
> +++ cfe/trunk/tools/libclang/CXCompilationDatabase.cpp Sun Aug 18 02:57:43 2013
> @@ -1,6 +1,7 @@
> #include "clang-c/CXCompilationDatabase.h"
> #include "CXString.h"
> #include "clang/Tooling/CompilationDatabase.h"
> +#include <stdio.h>
> 
> using namespace clang;
> using namespace clang::tooling;
> 
> Modified: cfe/trunk/tools/libclang/Indexing.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/libclang/Indexing.cpp?rev=188625&r1=188624&r2=188625&view=diff
> ==============================================================================
> --- cfe/trunk/tools/libclang/Indexing.cpp (original)
> +++ cfe/trunk/tools/libclang/Indexing.cpp Sun Aug 18 02:57:43 2013
> @@ -31,6 +31,7 @@
> #include "llvm/Support/MemoryBuffer.h"
> #include "llvm/Support/Mutex.h"
> #include "llvm/Support/MutexGuard.h"
> +#include <stdio.h>
> 
> using namespace clang;
> using namespace cxtu;
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits




More information about the cfe-commits mailing list