[PATCH] cpp11-migrate: Add a class to support include directives modifications (Windows bot fix)

Guillaume Papin guillaume.papin at epitech.eu
Mon Aug 19 05:24:00 PDT 2013


Hi revane, arielbernal, tareqsiraj,

This is the same patch as here: http://llvm-reviews.chandlerc.com/D1287

The unit tests broke the Windows bot so I changed them, updated files since D1287 are:
- unittests/cpp11-migrate/VirtualFileHelper.h (use std::string instead of
  StringRef in 'struct VirtualFile', since it's used as long lived object)
- unittests/cpp11-migrate/IncludeDirectivesTest.cpp:
  - Before I used an absolute path "/virtual/" as a prefix for the includes. My
    guess is that the Windows bots broke because of the missing drive letter (e.g:
    C:/).
  - Now the tests use "./" as a prefix for the headers. It should hopefully fix
    the issue on Windows.

http://llvm-reviews.chandlerc.com/D1438

Files:
  cpp11-migrate/Core/CMakeLists.txt
  cpp11-migrate/Core/IncludeDirectives.cpp
  cpp11-migrate/Core/IncludeDirectives.h
  unittests/cpp11-migrate/CMakeLists.txt
  unittests/cpp11-migrate/IncludeDirectivesTest.cpp
  unittests/cpp11-migrate/VirtualFileHelper.h
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D1438.1.patch
Type: text/x-patch
Size: 40331 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130819/d2d8789b/attachment.bin>


More information about the cfe-commits mailing list