[PATCH] Header dependencies support for modularize

[Sean Silva]

+// The most common (but not all) options to modularize that take
+// an argument in the following slot.
+// Note: This needs to be kept in sync with new or removed Clang arguments.
+// But hopefully modularize users won't need too many of these
+// kinds of arguments.
+const char *AddDependenciesAdjuster::OptionsWithArgument[] = {

Is there no better way to do this? I think libOption should expose the info
you need.

-- Sean Silva


On Fri, Aug 16, 2013 at 8:42 AM, Thompson, John <
John_Thompson at playstation.sony.com> wrote:

> A quick review anyone?
>
> Thanks.
>
> -John
>
> -----Original Message-----
> From: cfe-commits-bounces at cs.uiuc.edu [mailto:
> cfe-commits-bounces at cs.uiuc.edu] On Behalf Of John Thompson
> Sent: Tuesday, August 13, 2013 11:11 AM
> To: john.thompson.jtsoftware at gmail.com
> Cc: cfe-commits at cs.uiuc.edu
> Subject: [PATCH] Header dependencies support for modularize
>
> In using modularize to check a large group of platform headers for
> modules-readiness, I found that a few headers had dependencies, such that
> they required other headers to be included first to avoid compile errors on
> missing definitions.
>
> This patch adds support to modularize to allow specifying depended-on
> headers in the header file list input to modularize, i.e.
>
> header.h: dependency1.h dependency2.h
>
>
> http://llvm-reviews.chandlerc.com/D1383
>
> Files:
>   test/modularize/NoProblemsDependencies.modularize
>   test/modularize/Inputs/SomeOtherTypes.h
>   test/modularize/Inputs/IsDependent.h
>   modularize/Modularize.cpp
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130817/91c851eb/attachment.html>