r188574 - Need summary info. about arguments to

[Jordan Rose]

This isn't correct -- getMethodSummary and getFunctionSummary already do this where allowed, and they handle the special cases where the analyzer hardcodes better effects than what the annotations say. What problem were you seeing?

Jordan

On Aug 16, 2013, at 13:23 , Fariborz Jahanian <fjahanian at apple.com> wrote:

> Author: fjahanian
> Date: Fri Aug 16 15:23:36 2013
> New Revision: 188574
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=188574&view=rev
> Log:
> Need summary info. about arguments to
> CF functions coming from static analyzer API.
> 
> 
> Modified:
>    cfe/trunk/lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp
> 
> Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp?rev=188574&r1=188573&r2=188574&view=diff
> ==============================================================================
> --- cfe/trunk/lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp (original)
> +++ cfe/trunk/lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp Fri Aug 16 15:23:36 2013
> @@ -3701,6 +3701,7 @@ namespace clang { namespace ento { names
>   const RetainSummary *S = M.get ## KIND ## Summary(D);\
>   CallEffects CE(S->getRetEffect());\
>   CE.Receiver = S->getReceiverEffect();\
> +  M.updateSummaryFromAnnotations(S, D);\
>   unsigned N = S->getNumArgs();\
>   for (unsigned i = 0; i < N; ++i) {\
>     CE.Args.push_back(S->getArg(i));\
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits