[PATCH] Rewrite eachOf/allOf/anyOf to use a variadic operator.

Manuel Klimek klimek at google.com
Fri Aug 16 11:46:53 PDT 2013


  Why can't we base this on VariadicFunction instead of introducing yet-another-variadic-template-workaround?


================
Comment at: lib/ASTMatchers/ASTMatchersInternal.cpp:61
@@ +60,3 @@
+    BoundNodesTreeBuilder BuilderI(*Builder);
+    bool MatchedI = InnerMatchers[i]->matches(DynNode, Finder, &BuilderI);
+    if (MatchedI) {
----------------
Any reason to have this variable pulled out?

================
Comment at: lib/ASTMatchers/ASTMatchersInternal.cpp:60
@@ +59,3 @@
+  for (size_t i = 0, e = InnerMatchers.size(); i != e; ++i) {
+    BoundNodesTreeBuilder BuilderI(*Builder);
+    bool MatchedI = InnerMatchers[i]->matches(DynNode, Finder, &BuilderI);
----------------
I assume "I" stands for "Inner"? I'd rather type that out ;) (here and below)


http://llvm-reviews.chandlerc.com/D1427



More information about the cfe-commits mailing list