r188465 - Thread safety analysis: move warnings within lock/unlock functions out of beta.
DeLesley Hutchins
delesley at google.com
Thu Aug 15 08:31:25 PDT 2013
Author: delesley
Date: Thu Aug 15 10:31:25 2013
New Revision: 188465
URL: http://llvm.org/viewvc/llvm-project?rev=188465&view=rev
Log:
Thread safety analysis: move warnings within lock/unlock functions out of beta.
Modified:
cfe/trunk/lib/Analysis/ThreadSafety.cpp
Modified: cfe/trunk/lib/Analysis/ThreadSafety.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Analysis/ThreadSafety.cpp?rev=188465&r1=188464&r2=188465&view=diff
==============================================================================
--- cfe/trunk/lib/Analysis/ThreadSafety.cpp (original)
+++ cfe/trunk/lib/Analysis/ThreadSafety.cpp Thu Aug 15 10:31:25 2013
@@ -2352,8 +2352,6 @@ void ThreadSafetyAnalyzer::runAnalysis(A
= dyn_cast<SharedLocksRequiredAttr>(Attr)) {
getMutexIDs(SharedLocksToAdd, A, (Expr*) 0, D);
} else if (UnlockFunctionAttr *A = dyn_cast<UnlockFunctionAttr>(Attr)) {
- if (!Handler.issueBetaWarnings())
- return;
// UNLOCK_FUNCTION() is used to hide the underlying lock implementation.
// We must ignore such methods.
if (A->args_size() == 0)
@@ -2363,15 +2361,11 @@ void ThreadSafetyAnalyzer::runAnalysis(A
getMutexIDs(LocksReleased, A, (Expr*) 0, D);
} else if (ExclusiveLockFunctionAttr *A
= dyn_cast<ExclusiveLockFunctionAttr>(Attr)) {
- if (!Handler.issueBetaWarnings())
- return;
if (A->args_size() == 0)
return;
getMutexIDs(ExclusiveLocksAcquired, A, (Expr*) 0, D);
} else if (SharedLockFunctionAttr *A
= dyn_cast<SharedLockFunctionAttr>(Attr)) {
- if (!Handler.issueBetaWarnings())
- return;
if (A->args_size() == 0)
return;
getMutexIDs(SharedLocksAcquired, A, (Expr*) 0, D);
More information about the cfe-commits
mailing list