[PATCH] [-cxx-abi microsoft] Mangle member pointers better
Reid Kleckner
rnk at google.com
Wed Aug 14 17:14:33 PDT 2013
LGTM
================
Comment at: test/CodeGenCXX/mangle-ms.cpp:16
@@ -15,3 +15,3 @@
// CHECK: @"\01?j@@3P6GHCE at ZA"
-// CHECK: @"\01?k@@3PTfoo@@DQ1@"
+// X64: @"\01?k@@3PETfoo@@DET1@"
// CHECK: @"\01?l@@3P8foo@@AEHH at ZQ1@"
----------------
Shouldn't you leave the original check?
================
Comment at: lib/AST/MicrosoftMangle.cpp:997
@@ -996,3 +1001,1 @@
} else {
- if (PointersAre64Bit)
- Out << 'E';
----------------
Yeah, it makes more sense to move this out of mangleQualifiers and into the places where we know we have a member pointer.
http://llvm-reviews.chandlerc.com/D1353
BRANCH
PR16835+PR16848
ARCANIST PROJECT
clang
More information about the cfe-commits
mailing list