r188324 - sizeof(void) etc. should be a hard error in C++.

Howard Hinnant hhinnant at apple.com
Wed Aug 14 14:30:58 PDT 2013


libc++ fix committed revision 188413.

Howard

On Aug 14, 2013, at 3:19 PM, Howard Hinnant <hhinnant at apple.com> wrote:

> 90% sure you're correct Eli.  I'm running libc++ tests now on a fix (to get us up to 100%).
> 
> Howard
> 
> On Aug 14, 2013, at 2:12 PM, Eli Friedman <eli.friedman at gmail.com> wrote:
> 
>> Howard, would you mind taking a look?  This looks like a libcxx bug.
>> 
>> -Eli
>> 
>> On Wed, Aug 14, 2013 at 11:04 AM, Arnold Schwaighofer <aschwaighofer at apple.com> wrote:
>> Eli,
>> 
>> I think this commit broke the libcxx tester http://lab.llvm.org:8013/builders/libcxx_clang-x86_64-darwin11-RA/builds/258:
>> 
>> http://lab.llvm.org:8013/builders/libcxx_clang-x86_64-darwin11-RA/builds/258/steps/test.libcxx.system/logs/libc%2B%2B%20%3A%3A%20utilities__function.objects__refwrap__refwrap.invoke__invoke_void_0.pass.cpp
>> 
>> 
>> /Users/buildslave/zorg/buildbot/smooshlab/slave-0.8/build.libcxx_clang-x86_64-darwin11-RA/sources/include/type_traits:2910:19: error: invalid application of 'sizeof' to an incomplete type 'void'
>>    static_assert(sizeof(_Tp) > 0, "Type must be complete.”);
>> 
>> 
>> On Aug 13, 2013, at 5:26 PM, Eli Friedman <eli.friedman at gmail.com> wrote:
>> 
>>> http://llvm.org/viewvc/llvm-project?rev=188324&view=rev
>> 
>> 
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits





More information about the cfe-commits mailing list