[libc++] Patch for AIX port

[Howard Hinnant]

Thanks!  Committed revision 188396.

Howard

On Aug 14, 2013, at 1:04 PM, Xing Xue <xingxue at ca.ibm.com> wrote:

> Hi Howard,
> 
> Sure.  I've revised as follows.
> 
> Diffs:
> (See attached file: buildit.diffs)
> 
> The actual file:
> (See attached file: buildit)
> 
> However, the code in question does not seem to work to me.  Notice libc++.so.1.0 is generated because of "-o libc++.so.1.0" in line 103.  The 'ln -s libc++.so.1 libc++.so' command in line 141 will fail.  That's why line 141 was changed to 'ln -s libc++.so.1.0" in the previous patch.  I think the proper fix will be to change line 103 to "-o libc++.so.1" to be consistent with the soname.
> 
> ...
> 100   *)
> 101     RC_CFLAGS="-fPIC"
> 102     SOEXT=so
> 103     LDSHARED_FLAGS="-o libc++.so.1.0 \
> 104         -shared -nodefaultlibs -Wl,-soname,libc++.so.1 \
> 105         -lpthread -lrt -lc -lstdc++"
> 106     ;;
> ....
> 139     *)
> 140         rm -f libc++.so
> 141         ln -s libc++.so.1 libc++.so
> 142         ;;
> 
> Thanks,
> Xing Xue
> XLC++ Compiler Development / IBM Software Solutions Toronto Lab.
> Tie Line: 313-3972  Phone: 905-413-3972 Email: xingxue at ca.ibm.com
> 
> 
> 
> <graycol.gif>Howard Hinnant ---08/14/2013 10:00:34 AM---On Aug 14, 2013, at 3:45 AM, David Chisnall <theraven at FreeBSD.org> wrote: >>        rm -f libc++.so
> 
> <ecblank.gif>
> From:
> <ecblank.gif>
> Howard Hinnant <hhinnant at apple.com>
> <ecblank.gif>
> To:
> <ecblank.gif>
> Xing Xue/Toronto/IBM at IBMCA
> <ecblank.gif>
> Cc:
> <ecblank.gif>
> "cfe-commits at cs.uiuc.edu cfe" <cfe-commits at cs.uiuc.edu>, David Chisnall <theraven at FreeBSD.org>, Michael Wong/Toronto/IBM at IBMCA, "compnerd at compnerd.org Abdulrasool" <compnerd at compnerd.org>, Dimitry Andric <dimitry at andric.com>, "Andrew C. Morrow" <andrew.c.morrow at gmail.com>, aep at exys.org, joerg at NetBSD.org, "jyasskin at google.com Yasskin" <jyasskin at google.com>
> <ecblank.gif>
> Date:
> <ecblank.gif>
> 08/14/2013 10:00 AM
> <ecblank.gif>
> Subject:
> <ecblank.gif>
> Re: [libc++] Patch for AIX port
> 
> 
> 
> 
> On Aug 14, 2013, at 3:45 AM, David Chisnall <theraven at FreeBSD.org> wrote:
> 
> >>        rm -f libc++.so
> >> -        ln -s libc++.so.1 libc++.so
> >> +        ln -s libc++.so.1.0 libc++.so
> >>        ;;
> >> esac
> >> 
> >> All, please examine the last line:
> >> 
> >> -        ln -s libc++.so.1 libc++.so
> >> +        ln -s libc++.so.1.0 libc++.so
> > 
> > This does, however.  We don't usually use a.b version numbers.  It isn't of vital importance, however, as we don't use the upstream build system for the libc++ that we ship, although it would be mildly inconvenient for people who are building a newer version for testing.
> > 
> > Oh, and ln -sf is generally better than rm then ln, as it allows the operation to be atomic.
> 
> Xing, can you rework this part so that it is -ibm-only?
> 
> Howard
> 
> 
> 
> <buildit.diffs><buildit>