r188354 - [tests] Ensure subsitution string is ascii.

NAKAMURA Takumi geek4civic at gmail.com
Wed Aug 14 08:14:53 PDT 2013


Daniel, I have reverted it in r188373, excuse me.
ShParser.parse_command() was confused with unicode str.

I didn't understand decode('ascii') here. Let me know what your motivation is.

...Takumi

2013/8/14 Daniel Dunbar <daniel at zuster.org>:
> Author: ddunbar
> Date: Wed Aug 14 00:05:39 2013
> New Revision: 188354
>
> URL: http://llvm.org/viewvc/llvm-project?rev=188354&view=rev
> Log:
> [tests] Ensure subsitution string is ascii.
>
> Modified:
>     cfe/trunk/test/lit.cfg
>
> Modified: cfe/trunk/test/lit.cfg
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/lit.cfg?rev=188354&r1=188353&r2=188354&view=diff
> ==============================================================================
> --- cfe/trunk/test/lit.cfg (original)
> +++ cfe/trunk/test/lit.cfg Wed Aug 14 00:05:39 2013
> @@ -200,7 +200,7 @@ def getClangBuiltinIncludeDir(clang):
>      if sys.platform in ['win32'] and execute_external:
>          # Don't pass dosish path separator to msys bash.exe.
>          dir = dir.replace('\\', '/')
> -    return dir
> +    return dir.decode('ascii')
>
>  config.substitutions.append( ('%clang_cc1', '%s -cc1 -internal-isystem %s'
>                                % (config.clang,
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits



More information about the cfe-commits mailing list