r188335 - Refine diagnostics in my last patch.

Fariborz Jahanian fjahanian at apple.com
Tue Aug 13 17:07:10 PDT 2013


Author: fjahanian
Date: Tue Aug 13 19:07:10 2013
New Revision: 188335

URL: http://llvm.org/viewvc/llvm-project?rev=188335&view=rev
Log:
Refine diagnostics in my last patch.
// rdar://14303083

Modified:
    cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
    cfe/trunk/test/SemaObjC/objc-array-literal.m

Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td?rev=188335&r1=188334&r2=188335&view=diff
==============================================================================
--- cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td (original)
+++ cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td Tue Aug 13 19:07:10 2013
@@ -1899,7 +1899,8 @@ def warn_objc_string_literal_comparison
   "direct comparison of a string literal has undefined behavior">, 
   InGroup<ObjCStringComparison>;
 def warn_concatenated_nsarray_literal : Warning<
-  "concatenated nsstring literal for an nsarray expression">,
+  "concatenated NSString literal for an NSArray expression - "
+  "possibly missing a comma">,
   InGroup<ObjCStringConcatenation>;
 def note_objc_literal_comparison_isequal : Note<
   "use 'isEqual:' instead">;

Modified: cfe/trunk/test/SemaObjC/objc-array-literal.m
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaObjC/objc-array-literal.m?rev=188335&r1=188334&r2=188335&view=diff
==============================================================================
--- cfe/trunk/test/SemaObjC/objc-array-literal.m (original)
+++ cfe/trunk/test/SemaObjC/objc-array-literal.m Tue Aug 13 19:07:10 2013
@@ -43,5 +43,5 @@ int main() {
 // rdar://14303083
 id Test14303083() {
   id obj = @[ @"A", (@"B" @"C")];
-  return @[ @"A", @"B" @"C"]; // expected-warning {{concatenated nsstring literal for an nsarray expression}}
+  return @[ @"A", @"B" @"C"]; // expected-warning {{concatenated NSString literal for an NSArray expression - possibly missing a comma}}
 }





More information about the cfe-commits mailing list