[PATCH] CodeGen: __uuidof should work even with an incomplete _GUID type

Richard Smith richard at metafoo.co.uk
Tue Aug 13 13:20:35 PDT 2013


  LGTM (though I wonder if we should have a check in Sema that sizeof(_GUID) == 16 when we see its definition).


================
Comment at: lib/CodeGen/CodeGenModule.cpp:1063
@@ -1074,3 +1062,3 @@
       /*isConstant=*/true, llvm::GlobalValue::ExternalLinkage, Init, Name);
   GV->setUnnamedAddr(true);
   return GV;
----------------
Is unnamed_addr really correct for these things?


http://llvm-reviews.chandlerc.com/D1375



More information about the cfe-commits mailing list