r188256 - clang-format: Improve boolean expression formatting in macros.
Daniel Jasper
djasper at google.com
Tue Aug 13 02:09:09 PDT 2013
Author: djasper
Date: Tue Aug 13 04:09:09 2013
New Revision: 188256
URL: http://llvm.org/viewvc/llvm-project?rev=188256&view=rev
Log:
clang-format: Improve boolean expression formatting in macros.
Before:
#define IF(a, b, c) if (a&&(b == c))
After:
#define IF(a, b, c) if (a && (b == c))
Modified:
cfe/trunk/lib/Format/TokenAnnotator.cpp
cfe/trunk/unittests/Format/FormatTest.cpp
Modified: cfe/trunk/lib/Format/TokenAnnotator.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Format/TokenAnnotator.cpp?rev=188256&r1=188255&r2=188256&view=diff
==============================================================================
--- cfe/trunk/lib/Format/TokenAnnotator.cpp (original)
+++ cfe/trunk/lib/Format/TokenAnnotator.cpp Tue Aug 13 04:09:09 2013
@@ -93,7 +93,8 @@ private:
}
}
- if (Left->Previous && Left->Previous->is(tok::kw_static_assert))
+ if (Left->Previous && Left->Previous->isOneOf(tok::kw_static_assert,
+ tok::kw_if, tok::kw_while))
Contexts.back().IsExpression = true;
if (StartsObjCMethodExpr) {
Modified: cfe/trunk/unittests/Format/FormatTest.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/Format/FormatTest.cpp?rev=188256&r1=188255&r2=188256&view=diff
==============================================================================
--- cfe/trunk/unittests/Format/FormatTest.cpp (original)
+++ cfe/trunk/unittests/Format/FormatTest.cpp Tue Aug 13 04:09:09 2013
@@ -3712,6 +3712,8 @@ TEST_F(FormatTest, UnderstandsRvalueRefe
verifyFormat("template <bool B, bool C> class A {\n"
" static_assert(B && C, \"Something is wrong\");\n"
"};");
+ verifyGoogleFormat("#define IF(a, b, c) if (a && (b == c))");
+ verifyGoogleFormat("#define WHILE(a, b, c) while (a && (b == c))");
}
TEST_F(FormatTest, FormatsBinaryOperatorsPrecedingEquals) {
More information about the cfe-commits
mailing list