[PATCH] [libcxx] Distinguish between MSVC, MSVCRT, and Windows-specific code

G M gmisocpp at gmail.com
Mon Aug 12 18:31:08 PDT 2013


Hello

Could someone please consider this patch to libcxx. it's an improvement and
replacement to my prior patch that has yet to be committed. More details
about this and the prior patch can be found in previous messages with the
same subject line as this message.

I believe this patch is required as an addition to Nico's patch 187593
unless that patch is reverted.

This patch restores the ability of libcxx to build "out of the box" on
Windows. This patch fixes a typo in my previous patch, adds a few more
comments, and in addition hopefully reduces conflicts caused by
improvements to more recent MS and GNU compilers, so hopefully there
are less errors using them. Otherwise it is conceptually the same as my
previous patch.

As this patch is intended to relate to libcxx on Windows only (so in that
sense it should be considered somewhat safe) and given that libcxx
doesn't currently compile on Windows at the moment and this patch restores
that, I hope this patch can be reviewed and committed or rejected soon as
the build on Windows has been broken for around a week now.

Thanks
Glen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130813/0bbed40a/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libcxx2.diff
Type: application/octet-stream
Size: 13173 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130813/0bbed40a/attachment.obj>


More information about the cfe-commits mailing list