[PATCH] clang-cl: Choose executable name base on input name or /Fe

[Reid Kleckner]

  LGTM


================
Comment at: lib/Driver/Driver.cpp:383
@@ -371,3 +382,3 @@
     StringRef V = A->getValue();
     if (V == "") {
       // It has to have a value.
----------------
Silly drive by thing: this could just be V.empty()

================
Comment at: lib/Driver/Driver.cpp:380
@@ -359,2 +379,3 @@
 
   if (Arg *A = C->getArgs().getLastArg(options::OPT__SLASH_Fo)) {
+    DiagnoseOptionOverride(*this, C->getArgs(), options::OPT__SLASH_Fo);
----------------
Stepping back, I don't think this diagnostic-only code belongs here.  It could be sunk into BuildActions or a helper or something.


http://llvm-reviews.chandlerc.com/D1344