[PATCH] cpp11-migrate: Write header replacements to disk

Edwin Vane edwin.vane at intel.com
Mon Aug 12 10:16:06 PDT 2013



================
Comment at: clang-tools-extra/trunk/cpp11-migrate/Core/ReplacementsYaml.h:27
@@ +26,3 @@
+  std::string TransformID;
+  std::vector<clang::tooling::Replacement> GeneratedReplacements;
+};
----------------
GeneratedReplacements -> Replacements

================
Comment at: clang-tools-extra/trunk/cpp11-migrate/Core/ReplacementsYaml.h:32
@@ +31,3 @@
+/// the TransformReplacements.
+struct TransformDocument {
+  std::string FileName;
----------------
TransformDocument -> HeaderChangeDocument. Also, since the plan is to only apply changes to headers one transform at a time, we no longer need a vector of TransformReplacements. Can just fold TransformReplacements into HeaderChangeDocument.

Also, can we add another field here to provide the name of the source file from which this change description was generated?

================
Comment at: clang-tools-extra/trunk/cpp11-migrate/Core/ReplacementsYaml.h:33
@@ +32,3 @@
+struct TransformDocument {
+  std::string FileName;
+  std::vector<TransformReplacements> Replacements;
----------------
Filename -> HeaderFileName


http://llvm-reviews.chandlerc.com/D1142

COMMIT
  http://llvm-reviews.chandlerc.com/rL187204



More information about the cfe-commits mailing list