[PATCH] Allow ExternalSemaSource to participate in typo correction

Luke Zarko zarko at google.com
Mon Aug 12 09:58:03 PDT 2013


Ping; still looking for a reviewer. The patch still applies without problems.

http://llvm-reviews.chandlerc.com/D1211

On Thu, Aug 8, 2013 at 9:23 AM, Luke Zarko <zarko at google.com> wrote:
> Ping; still looking for someone familiar with typo
> correction/unittests/ExternalSemaSource.
>
> On Sat, Aug 3, 2013 at 6:22 PM, Luke Zarko <zarko at google.com> wrote:
>> Ping. Looking for someone familiar with typo
>> correction/unittests/ExternalSemaSource.
>>
>> On Tue, Jul 30, 2013 at 3:41 PM, Luke Zarko <zarko at google.com> wrote:
>>>   Ping/making sure that this still applies cleanly.
>>>
>>>   To clarify, the difference between this and typo correction into PCH is that the calls for the latter are designed for a closed context ('fill a vector with all the namespaces you know about and return it to me'), whereas the former is designed for an open context ('I'll give you a qualified name and you tell me if it's something that exists').
>>>
>>> Hi jdennett,
>>>
>>> http://llvm-reviews.chandlerc.com/D1211
>>>
>>> CHANGE SINCE LAST DIFF
>>>   http://llvm-reviews.chandlerc.com/D1211?vs=3003&id=3083#toc
>>>
>>> Files:
>>>   include/clang/Sema/ExternalSemaSource.h
>>>   include/clang/Sema/MultiplexExternalSemaSource.h
>>>   lib/Sema/MultiplexExternalSemaSource.cpp
>>>   lib/Sema/SemaLookup.cpp
>>>   unittests/CMakeLists.txt
>>>   unittests/Makefile
>>>   unittests/Sema/CMakeLists.txt
>>>   unittests/Sema/ExternalSemaSourceTest.cpp
>>>   unittests/Sema/Makefile




More information about the cfe-commits mailing list