XCore target front end

[Eli Friedman]

On Mon, Aug 12, 2013 at 4:00 AM, Robert Lytton <robert at xmos.com> wrote:
> Hi Eli,
>
> Thank you for the review.
> I've moved relevant tests from test/CodeGen/xcore-abi.c to test/Driver/xcore-opts.c
>
> I've added a predicate function to the handling of no_common:
> ...
> if (KernelOrKext || isNoCommonDefault(getToolChain().getTriple())) {
>     if (!Args.hasArg(options::OPT_fcommon))
>       CmdArgs.push_back("-fno-common");
>     Args.ClaimAllArgs(options::OPT_fno_common);
>   }
> ...
>
> static bool isNoCommonDefault(const llvm::Triple &Triple) {
>   switch (Triple.getArch()) {
>   default:
>     return false;
>
>   case llvm::Triple::xcore:
>     return true;
>   }
> }
>
> updated patch attached.

LGTM.

-Eli