r188084 - Add a convenient way to compare GCCVersions without creating temporary objects.

Chandler Carruth chandlerc at google.com
Fri Aug 9 11:04:26 PDT 2013

On Fri, Aug 9, 2013 at 11:00 AM, Benjamin Kramer <benny.kra at gmail.com>wrote:

> The list initializer version mentions the version number twice, I found
> that really ugly and the version string isn't used at all. I guess we could
> always call GCCVersion::Parse if we don't care about performance (I don't
> think this code is hot).

We could give it constructors instead of using braced init, and then have:
GCCVersion(4, 1, 1) auto-produce a version string...

Meh, I don't *really* care, I just didn't find this solution terribly
elegant, but its also not terrible inelegant, so "meh". We can stop wasting
time here.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130809/574c2836/attachment.html>

More information about the cfe-commits mailing list