[patch] Correctly align arrays of int64_t on 32 bit systems

Richard Smith richard at metafoo.co.uk
Thu Aug 8 11:40:54 PDT 2013

On Thu, Aug 8, 2013 at 5:10 AM, Rafael EspĂ­ndola <rafael.espindola at gmail.com
> wrote:

> On 8 August 2013 01:36, Richard Smith <richard at metafoo.co.uk> wrote:
> > Typos 'conpute', 'allignof', and 'comput' in the comment.
> Fixed.

Looks like you're also missing an update to ASTContext.h to change the
parameter name there?

> I'm not really a big fan of ASTContext knowing about the semantics of the
> > GNU alignof extension like this, but the change looks correct. Changing
> the
> > comment to talk about semantic alignment versus ABI alignment would help
> > (but that doesn't cover the following-references /
> not-following-references
> > half).
> AST suffers from being the place we have for sharing code between Sema
> and Codegen. As you point out, "semantic" would be a bit vague as what
> we compute is specific to alignof.

I suspect we'll want to revisit this at some point, but LGTM for now.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130808/8df840da/attachment.html>

More information about the cfe-commits mailing list