[PATCH] [-cxx-abi microsoft] Mangle TemplateArgument::Declaration correctly for member pointers and references

Reid Kleckner rnk at google.com
Thu Aug 8 11:28:03 PDT 2013



================
Comment at: lib/AST/MicrosoftMangle.cpp:891
@@ +890,3 @@
+               getASTContext().getCharWidth();
+      mangleIntegerLiteral(Offset, false);
+    } else
----------------
There's a fair amount of complexity in member pointers.
- Can I mangle in a null data memptr here?
- The null representation is different between standard layout records (-1) and other records (0).
- Can I mangle a field from a base class that is not at offset 0?

All this is currently handled in CodeGen/MicrosoftCXXABI.cpp, which this AST code can't depend on.  We could raise some parts of it up into the AST CXXABI if needed.


http://llvm-reviews.chandlerc.com/D1323



More information about the cfe-commits mailing list