[PATCH] Introduce Replacement deduplication and conflict detection function

Manuel Klimek klimek at google.com
Thu Aug 8 10:05:42 PDT 2013

On Thu, Aug 8, 2013 at 6:14 AM, Edwin Vane <edwin.vane at intel.com> wrote:

>   1. I was concerned that although `Range` describes what I want that my
> use of it to describe an offset and number of consecutive items in a vector
> was against it's intended use as a **source** range.

Ooooh. Ok, I assumed the output of vector<Range> conflict would be
overlapping *source* ranges (apparently I didn't read closely enough, no
idea how I convinced myself that this makes sense :P)

In that case I'd suggest to either:
- use pair
- report conflicts as source ranges (which I'd personally prefer)
obviously fine as a follow-up patch.


>   2. Just making sure. When we switch `Replacements` to be an
> `std::vector` from `std::set` when deduplication happens this new function
> would be used which is doing something new from before: i.e. conflict
> detection.
>   3. That was the intention.
>   So ready to commit?
> http://llvm-reviews.chandlerc.com/D1314
>   dedup
>   clang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130808/97db46da/attachment.html>

More information about the cfe-commits mailing list