[PATCH] in C mode, __builtin_va_start tries to accept a reference, sees a record, decides it's a C++ class, then crashes because it isn't

[Artyom Skrobov]

Richard, my patch doesn't add support for reference types in C - it only adds the proper type-checking so that clang emits a meaningful error diagnostic in this case, instead of crashing with a segfault.


From: metafoo at gmail.com [mailto:metafoo at gmail.com] On Behalf Of Richard Smith
Sent: 08 August 2013 00:57
To: Artyom Skrobov
Cc: Anton Korobeynikov; cfe-commits at cs.uiuc.edu
Subject: Re: [PATCH] in C mode, __builtin_va_start tries to accept a reference, sees a record, decides it's a C++ class, then crashes because it isn't

This is truly hideous. Do we *really* want to support reference types in C, just so that we can handle __builtin_va_start?

On Tue, Aug 6, 2013 at 8:26 AM, Artyom Skrobov <Artyom.Skrobov at arm.com<mailto:Artyom.Skrobov at arm.com>> wrote:
Anton, thank you for your suggestion.

Re-submitting the patch as an attachment.


-----Original Message-----
From: Anton Korobeynikov [mailto:anton at korobeynikov.info<mailto:anton at korobeynikov.info>]
Sent: 05 August 2013 23:24
To: Artyom Skrobov
Cc: cfe-commits at cs.uiuc.edu<mailto:cfe-commits at cs.uiuc.edu>
Subject: Re: [PATCH] in C mode, __builtin_va_start tries to accept a reference, sees a record, decides it's a C++ class, then crashes because it isn't

Please consider reading http://llvm.org/docs/DeveloperPolicy.html#making-a-patch


-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium.  Thank you.

_______________________________________________
cfe-commits mailing list
cfe-commits at cs.uiuc.edu<mailto:cfe-commits at cs.uiuc.edu>
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits


-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130808/c3954866/attachment.html>