[patch] Correctly align arrays of int64_t on 32 bit systems

Richard Smith richard at metafoo.co.uk
Wed Aug 7 22:36:35 PDT 2013

Typos 'conpute', 'allignof', and 'comput' in the comment.

I'm not really a big fan of ASTContext knowing about the semantics of the
GNU alignof extension like this, but the change looks correct. Changing the
comment to talk about semantic alignment versus ABI alignment would help
(but that doesn't cover the following-references / not-following-references

On Wed, Aug 7, 2013 at 8:19 PM, Rafael EspĂ­ndola <rafael.espindola at gmail.com
> wrote:

> >> To quote Clang, 'alignof' applied to an expression is a GNU extension.
> >> Thus we should presumably do what GCC does -- C++ doesn't have a notion
> of
> >> the alignment of a declaration as distinct from the alignment of its
> type.
> >
> >
> > OK, so that's not strictly-speaking true, but it doesn't have a notion of
> > the alignment being increased because all globals happen to be 16-byte
> > aligned on the target system.
> The attached patch should fix it. Is it OK?
> Cheers,
> Rafael
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130807/466f4386/attachment.html>

More information about the cfe-commits mailing list