Can't stop myself: N3644 support for unordered containers

Howard Hinnant hhinnant at apple.com
Wed Aug 7 12:58:09 PDT 2013


Agreed with Kim's comments, plus:

In <unordered_map> the iterator default ctor treatment is superfluous, and thus confusing, so it should be removed.  These iterators are just wrapping __hash_iterator which you've correctly treated.

Please remove tests involving ii3.

Thanks!

Howard

On Aug 7, 2013, at 3:05 AM, Kim Gräsman <kim.grasman at gmail.com> wrote:

> Hi Marshall,
> 
> Drive-by comments:
> 
> - There are tab characters in a few places instead of spaces
> - Some commented-out blocks in the test files
> 
> FWIW,
> - Kim
> 
> On Tue, Aug 6, 2013 at 10:21 PM, Marshall Clow <mclow.lists at gmail.com> wrote:
>> This might be the last one…
>> 
>> -- Marshall
>> 
>> Marshall Clow     Idio Software   <mailto:mclow.lists at gmail.com>
>> 
>> A.D. 1517: Martin Luther nails his 95 Theses to the church door and is promptly moderated down to (-1, Flamebait).
>>        -- Yu Suzuki
>> 
>> 
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits





More information about the cfe-commits mailing list