[PATCH] clang-format: Fix some problems with Allman brace breaking

Manuel Klimek klimek at google.com
Wed Aug 7 08:08:34 PDT 2013


Do you need me to commit it?


On Wed, Aug 7, 2013 at 12:20 AM, Thomas Gibson-Robinson <
thomas.gibsonrobinson at gmail.com> wrote:

> Sorry about that: next time I'll make sure to use phabricator.
>
> Thanks for looking at the patch!
>
> On 6 Aug 2013, at 18:50, Manuel Klimek <klimek at google.com> wrote:
>
> LG. In the future, it would be cool if you could use phabricator (
> http://llvm-reviews.chandlerc.com/, docs at
> http://llvm.org/docs/Phabricator.html), as that makes it easier to review
> code in context.
>
> Thanks!
>
>
>
> On Mon, Aug 5, 2013 at 2:32 PM, Thomas Gibson-Robinson <
> thomas.gibsonrobinson at gmail.com> wrote:
>
>> The attached patch fixes a couple of bugs with the Allman brace breaking.
>> In particular, left braces after an enum declaration now occur on their own
>> line. Further, when short ifs/whiles are allowed these no longer cause the
>> left brace to be on the same line as the if/while when a brace is included.
>> Tests are included.
>>
>>
>>
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130807/adc80722/attachment.html>


More information about the cfe-commits mailing list