[PATCH] Indicate success for simple options when clang called with -cc1

Rafael EspĂ­ndola rafael.espindola at gmail.com
Wed Aug 7 05:41:14 PDT 2013


> Test created and new patch attached. I'm a bit uncertain about testing
> the "-analyzer-checker-help" option since that is within #ifdef
> CLANG_ENABLE_STATIC_ANALYZER in the code. Will this flag always be
> active when running the tests? If not how should I check this in the
> test?

It is probably best to leave it out. The patch LGTM with that changed.

> Perhaps I should mention that I don't have commit access so I will
> need help with that part later.

I will commit. Sorry for taking so long on the review.

Cheers,
Rafael



More information about the cfe-commits mailing list