[PATCH] clang-cl: Implement support for the /Fo option

Reid Kleckner rnk at google.com
Tue Aug 6 14:51:31 PDT 2013


Comment at: lib/Driver/Driver.cpp:1620
@@ +1619,3 @@
+      Filename.append(".");
+      // FIXME: For clang-cl, we want .obj rather than .o for object files.
+      Filename.append(types::getTypeTempSuffix(types::TY_Object));
Hans Wennborg wrote:
> Reid Kleckner wrote:
> > We're already dominated by a check for /Fo, which implies clang-cl mode, so I'd just hardcode this to append(".obj") and get this right on the first commit.  No need to go back and change the test.
> Yes, but clang-cl mode doesn't necessarily imply /Fo. It would be weird if we produced .obj files with /Fo and .o otherwise.
> I think it might be better to fix this in a separate patch.
OK, sounds good.


More information about the cfe-commits mailing list