[PATCH] AST: Properly mangle member pointers for Microsoft ABI
Reid Kleckner
rnk at google.com
Mon Aug 5 13:21:43 PDT 2013
LGTM
================
Comment at: lib/AST/MicrosoftMangle.cpp:336
@@ +335,3 @@
+ if (const MemberPointerType *MPT = Ty->getAs<MemberPointerType>())
+ mangleName(MPT->getClass()->getCanonicalTypeUnqualified()
+ .castAs<RecordType>()->getDecl());
----------------
Is getCanonicalTypeUnqualified() necessary? Would getAsCXXRecordDecl() suffice?
http://llvm-reviews.chandlerc.com/D1282
BRANCH
PR15900
ARCANIST PROJECT
clang
More information about the cfe-commits
mailing list