[Patch] lit.cfg: better check for MSYS

[Hans Wennborg]

On Tue, Jul 30, 2013 at 3:56 PM, Hans Wennborg <hans at chromium.org> wrote:
> On Mon, Jul 29, 2013 at 6:07 PM, Hans Wennborg <hans at chromium.org> wrote:
>> On Mon, Jul 29, 2013 at 3:28 PM, Reid Kleckner <rnk at google.com> wrote:
>>> bash -help is pretty fast to start, but it also seems pretty heavyweight for
>>> lit.cfg.  It's probably better to check not execute_external like this:
>>>
>>> $ git diff test/lit.cfg
>>> diff --git a/test/lit.cfg b/test/lit.cfg
>>> index a5bb350..f2f16fb 100644
>>> --- a/test/lit.cfg
>>> +++ b/test/lit.cfg
>>> @@ -245,7 +245,7 @@ if execute_external:
>>>      config.available_features.add('shell')
>>>
>>>  # Exclude MSYS due to transforming '/' to 'X:/mingwroot/'.
>>> -if not platform.system() in ['Windows'] or lit.getBashPath() == '':
>>> +if not platform.system() in ['Windows'] or not execute_external:
>>>      config.available_features.add('shell-preserves-root')
>>
>> That sounds good to me. Takumi, what do you think about this change? I
>> see we do (almost) the same check earlier in the file, in
>> getClangBuiltinIncludeDir().
>
> Ping?

Ping?