r187729 - [analyzer] Clarify that r187624 is a hack and should be fixed better later.

Jordan Rose jordan_rose at apple.com
Mon Aug 5 09:02:03 PDT 2013

Author: jrose
Date: Mon Aug  5 11:02:02 2013
New Revision: 187729

URL: http://llvm.org/viewvc/llvm-project?rev=187729&view=rev
[analyzer] Clarify that r187624 is a hack and should be fixed better later.

Tracked by <rdar://problem/14648821>.


Modified: cfe/trunk/lib/StaticAnalyzer/Core/BugReporter.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/StaticAnalyzer/Core/BugReporter.cpp?rev=187729&r1=187728&r2=187729&view=diff
--- cfe/trunk/lib/StaticAnalyzer/Core/BugReporter.cpp (original)
+++ cfe/trunk/lib/StaticAnalyzer/Core/BugReporter.cpp Mon Aug  5 11:02:02 2013
@@ -3205,6 +3205,9 @@ void BugReporter::emitReport(BugReport*
   // Defensive checking: throw the bug away if it comes from a BodyFarm-
   // generated body. We do this very early because report processing relies
   // on the report's location being valid.
+  // FIXME: Valid bugs can occur in BodyFarm-generated bodies, so really we
+  // need to just find a reasonable location like we do later on with the path
+  // pieces.
   if (const ExplodedNode *E = R->getErrorNode()) {
     const LocationContext *LCtx = E->getLocationContext();
     if (LCtx->getAnalysisDeclContext()->isBodyAutosynthesized())

More information about the cfe-commits mailing list