NULL iterators for <list>

Marshall Clow mclow.lists at gmail.com
Mon Aug 5 07:47:31 PDT 2013


On Aug 2, 2013, at 11:55 AM, Marshall Clow <mclow.lists at gmail.com> wrote:
> On Aug 2, 2013, at 11:24 AM, Howard Hinnant <hhinnant at apple.com> wrote:
> 
>> On Aug 1, 2013, at 1:05 PM, Marshall Clow <mclow.lists at gmail.com> wrote:
>> 
>>> http://std.org/jtc1/sc22/wg21/docs/papers/2013/n3644.pdf  says that value-initialized iterators should compare equal.
>>> 
>>> Implement that for std::list.
>>> 
>>> There are interactions with libc++'s debug mode; hence the extra tests.
>> 
>> Looks pretty good.  Just a couple of comments.

I think I've addressed your comments, and cleaned up the tests for == and != per our discussion.
Revised (and simpler) patch enclosed.
tested under C++03, C++11, C++1Y (each with and w/o debug)

-- Marshall

Marshall Clow     Idio Software   <mailto:mclow.lists at gmail.com>

A.D. 1517: Martin Luther nails his 95 Theses to the church door and is promptly moderated down to (-1, Flamebait).
        -- Yu Suzuki
-------------- next part --------------
A non-text attachment was scrubbed...
Name: n3644-list-3.patch
Type: application/octet-stream
Size: 3939 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130805/4213f8b0/attachment.obj>


More information about the cfe-commits mailing list