[PATCH] clang-cl: add more options

Hans Wennborg hans at chromium.org
Thu Aug 1 17:31:49 PDT 2013


  Thanks for the review!


================
Comment at: include/clang/Driver/CLCompatOptions.td:88
@@ +87,3 @@
+def _SLASH_Zc_forScope : CLIgnoredFlag<"Zc:forScope">;
+def _SLASH_Zcwchar_t : CLIgnoredFlag<"Zc:wchar_t">;
+
----------------
Reid Kleckner wrote:
> Not _SLASH_Zc_wchar_t?
Done.

================
Comment at: include/clang/Driver/CLCompatOptions.td:110
@@ +109,3 @@
+def _SLASH_MTd : CLFlag<"MTd">;
+def _SLASH_Ob : CLFlag<"Ob">;
+def _SLASH_Oi : CLFlag<"Oi">;
----------------
Reid Kleckner wrote:
> We should alias /Ob0 to -fno-inline.  We can ignore /ObN for N != 0
Done.

================
Comment at: include/clang/Driver/CLCompatOptions.td:120
@@ +119,2 @@
+def _SLASH_ZI : CLFlag<"ZI">;
+def _SLASH_Zi : CLFlag<"Zi">;
----------------
Reid Kleckner wrote:
> I suppose you could toss /showIncludes on here, since we'll need that.
Done.


http://llvm-reviews.chandlerc.com/D1264



More information about the cfe-commits mailing list