Unify unix and windows versions of FileManager::UniqueDirContainer and FileManager::UniqueFileContainer

Rafael EspĂ­ndola rafael.espindola at gmail.com
Wed Jul 31 12:27:20 PDT 2013


On 31 July 2013 14:57, Sean Silva <silvas at purdue.edu> wrote:
> -      ::Emit32(Out, (uint32_t) StatBuf->st_ino);
> -      ::Emit32(Out, (uint32_t) StatBuf->st_dev);
> -      ::Emit16(Out, (uint16_t) StatBuf->st_mode);
> -      ::Emit64(Out, (uint64_t) StatBuf->st_mtime);
> -      ::Emit64(Out, (uint64_t) StatBuf->st_size);
> -      delete StatBuf;
> +      ::Emit64(Out, Data->UniqueID.getFile());
> +      ::Emit64(Out, Data->UniqueID.getDevice());
> +      ::Emit64(Out, Data->ModTime);
> +      ::Emit64(Out, Data->Size);
> +      delete Data;
>
> This seems like it changes the PTH file format. Is there some format version
> number you need to bump somewhere? Or is this a "private" format?

I was assuming it was private. I.E., the reader must be the same as
the writer. Is that not the case?

> -- Sean Silva

Cheers,
Rafael



More information about the cfe-commits mailing list