[PATCH] Fix PR16735 - emit the constructor for abstract classes
Reid Kleckner
rnk at google.com
Wed Jul 31 10:28:42 PDT 2013
================
Comment at: lib/CodeGen/CGCXX.cpp:185
@@ -184,3 @@
- // ignores virtual bases.
- if (getTarget().getCXXABI().hasConstructorVariants())
- EmitGlobal(GlobalDecl(D, Ctor_Base));
----------------
This seems fine. Alternatively, we could consider Ctor_Base to be the "true" ctor variant that we always emit, and alias Ctor_Complete to Ctor_Base the way we do for dtors of classes with no virtual bases. I'm not sure how invasive that would be.
http://llvm-reviews.chandlerc.com/D1248
More information about the cfe-commits
mailing list