r187330 - Try single quotes to fix the msys bot:

Rafael EspĂ­ndola rafael.espindola at gmail.com
Mon Jul 29 13:23:12 PDT 2013


Thanks!

On 29 July 2013 14:44, Hans Wennborg <hans at chromium.org> wrote:
> Thanks for trying to fix this! Sorry I wasn't around to catch the fail.
>
> I have removed the quotes around /help again and changed back the
> comment in r187366 since it didn't really help and Takumi found a
> better fix.
>
> Thanks,
> Hans
>
> On Sun, Jul 28, 2013 at 10:13 AM, Rafael Espindola
> <rafael.espindola at gmail.com> wrote:
>> Author: rafael
>> Date: Sun Jul 28 12:13:24 2013
>> New Revision: 187330
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=187330&view=rev
>> Log:
>> Try single quotes to fix the msys bot:
>>
>> It was still failing with double quotes:
>>
>> http://bb.pgr.jp/builders/clang-i686-msys/builds/698/steps/test_clang/logs/Clang%20%3A%3A%20Driver__cl.c
>>
>> Modified:
>>     cfe/trunk/test/Driver/cl.c
>>
>> Modified: cfe/trunk/test/Driver/cl.c
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/cl.c?rev=187330&r1=187329&r2=187330&view=diff
>> ==============================================================================
>> --- cfe/trunk/test/Driver/cl.c (original)
>> +++ cfe/trunk/test/Driver/cl.c Sun Jul 28 12:13:24 2013
>> @@ -1,19 +1,18 @@
>> -// Note: we have to quote the /? option, otherwise some shells will try
>> -// to expand the ? into a one-letter filename in the root directory,
>> -// and make the test fail if such a file or directory exists.
>> +// Note: we have to quote the options with a /, otherwise some shells will try
>> +// to expand it and make test fail.
>>
>>  // Check that clang-cl options are not available by default.
>>  // RUN: %clang -help | FileCheck %s -check-prefix=DEFAULT
>>  // DEFAULT-NOT: CL.EXE COMPATIBILITY OPTIONS
>>  // DEFAULT-NOT: {{/[?]}}
>>  // DEFAULT-NOT: /help
>> -// RUN: not %clang "/?"
>> +// RUN: not %clang '/?'
>>  // RUN: not %clang -?
>> -// RUN: not %clang /help
>> +// RUN: not %clang '/help'
>>
>> -// Check that "/?" and /help are available as clang-cl options.
>> -// RUN: %clang_cl "/?" | FileCheck %s -check-prefix=CL
>> -// RUN: %clang_cl /help | FileCheck %s -check-prefix=CL
>> +// Check that '/?' and '/help' are available as clang-cl options.
>> +// RUN: %clang_cl '/?' | FileCheck %s -check-prefix=CL
>> +// RUN: %clang_cl '/help' | FileCheck %s -check-prefix=CL
>>  // RUN: %clang_cl -help | FileCheck %s -check-prefix=CL
>>  // CL: CL.EXE COMPATIBILITY OPTIONS
>>  // CL: {{/[?]}}
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits



More information about the cfe-commits mailing list