r187330 - Try single quotes to fix the msys bot:

[Rafael Avila de Espindola]

Any idea on how to xfail this?

Sent from my iPhone

On 2013-07-28, at 13:38, Reid Kleckner <rnk at google.com> wrote:

> The msys shell is applying these transformations:
> http://www.mingw.org/wiki/Posix_path_conversion
> 
> It looks like this commit didn't fix the test, and that page doesn't show any way to avoid this conversion.
> 
> 
> On Sun, Jul 28, 2013 at 1:13 PM, Rafael Espindola <rafael.espindola at gmail.com> wrote:
>> Author: rafael
>> Date: Sun Jul 28 12:13:24 2013
>> New Revision: 187330
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=187330&view=rev
>> Log:
>> Try single quotes to fix the msys bot:
>> 
>> It was still failing with double quotes:
>> 
>> http://bb.pgr.jp/builders/clang-i686-msys/builds/698/steps/test_clang/logs/Clang%20%3A%3A%20Driver__cl.c
>> 
>> Modified:
>>     cfe/trunk/test/Driver/cl.c
>> 
>> Modified: cfe/trunk/test/Driver/cl.c
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/cl.c?rev=187330&r1=187329&r2=187330&view=diff
>> ==============================================================================
>> --- cfe/trunk/test/Driver/cl.c (original)
>> +++ cfe/trunk/test/Driver/cl.c Sun Jul 28 12:13:24 2013
>> @@ -1,19 +1,18 @@
>> -// Note: we have to quote the /? option, otherwise some shells will try
>> -// to expand the ? into a one-letter filename in the root directory,
>> -// and make the test fail if such a file or directory exists.
>> +// Note: we have to quote the options with a /, otherwise some shells will try
>> +// to expand it and make test fail.
>> 
>>  // Check that clang-cl options are not available by default.
>>  // RUN: %clang -help | FileCheck %s -check-prefix=DEFAULT
>>  // DEFAULT-NOT: CL.EXE COMPATIBILITY OPTIONS
>>  // DEFAULT-NOT: {{/[?]}}
>>  // DEFAULT-NOT: /help
>> -// RUN: not %clang "/?"
>> +// RUN: not %clang '/?'
>>  // RUN: not %clang -?
>> -// RUN: not %clang /help
>> +// RUN: not %clang '/help'
>> 
>> -// Check that "/?" and /help are available as clang-cl options.
>> -// RUN: %clang_cl "/?" | FileCheck %s -check-prefix=CL
>> -// RUN: %clang_cl /help | FileCheck %s -check-prefix=CL
>> +// Check that '/?' and '/help' are available as clang-cl options.
>> +// RUN: %clang_cl '/?' | FileCheck %s -check-prefix=CL
>> +// RUN: %clang_cl '/help' | FileCheck %s -check-prefix=CL
>>  // RUN: %clang_cl -help | FileCheck %s -check-prefix=CL
>>  // CL: CL.EXE COMPATIBILITY OPTIONS
>>  // CL: {{/[?]}}
>> 
>> 
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130728/e73d0a97/attachment.html>