r187295 - Fix test/Driver/cl.c.

Hans Wennborg hans at hanshq.net
Fri Jul 26 23:19:03 PDT 2013


Author: hans
Date: Sat Jul 27 01:19:03 2013
New Revision: 187295

URL: http://llvm.org/viewvc/llvm-project?rev=187295&view=rev
Log:
Fix test/Driver/cl.c.

This test would fail in weird ways on systems with a one-letter filename
in the root directory, because the shell would helpfully expand /? to e.g. /n.

Make sure this doesn't happen by adding quotes.

Modified:
    cfe/trunk/test/Driver/cl.c

Modified: cfe/trunk/test/Driver/cl.c
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/cl.c?rev=187295&r1=187294&r2=187295&view=diff
==============================================================================
--- cfe/trunk/test/Driver/cl.c (original)
+++ cfe/trunk/test/Driver/cl.c Sat Jul 27 01:19:03 2013
@@ -1,14 +1,18 @@
+// Note: we have to quote the /? option, otherwise some shells will try
+// to expand the ? into a one-letter filename in the root directory,
+// and make the test fail if such a file or directory exists.
+
 // Check that clang-cl options are not available by default.
 // RUN: %clang -help | FileCheck %s -check-prefix=DEFAULT
 // DEFAULT-NOT: CL.EXE COMPATIBILITY OPTIONS
 // DEFAULT-NOT: {{/[?]}}
 // DEFAULT-NOT: /help
-// RUN: not %clang /?
+// RUN: not %clang "/?"
 // RUN: not %clang -?
 // RUN: not %clang /help
 
-// Check that /? and /help are available as clang-cl options.
-// RUN: %clang_cl /? | FileCheck %s -check-prefix=CL
+// Check that "/?" and /help are available as clang-cl options.
+// RUN: %clang_cl "/?" | FileCheck %s -check-prefix=CL
 // RUN: %clang_cl /help | FileCheck %s -check-prefix=CL
 // RUN: %clang_cl -help | FileCheck %s -check-prefix=CL
 // CL: CL.EXE COMPATIBILITY OPTIONS





More information about the cfe-commits mailing list