[PATCH] Last-chance diagnostics for incomplete types

[James Dennett]

================
Comment at: include/clang/Sema/MultiplexExternalSemaSource.h:325
@@ -324,1 +324,3 @@
 
+  virtual bool MaybeDiagnoseMissingCompleteType(SourceLocation Loc, QualType T);
+
----------------
Please document this, even if it's just inheriting docs and then saying how this implements the interface.

================
Comment at: include/clang/Sema/ExternalSemaSource.h:183
@@ +182,3 @@
+  /// \brief Produces a diagnostic note if the external source contains a
+  /// complete definition for T.
+  ///
----------------
Nit: "\p T" -> "T" to refer to the parameter T.


http://llvm-reviews.chandlerc.com/D1213