[PATCH] clang-cl: add support for /? and /help

Hans Wennborg hans at chromium.org
Wed Jul 24 16:24:26 PDT 2013


Hi rnk, chandlerc,

Chandler requested that I take this patch to Phabricator to make it easier to look at, so here it goes.

(Please bear with me, this is my first attempt at uploading to this tool.)

Original email thread is here: http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20130722/084370.html

On Tue, Jul 23, 2013 at 3:46 PM, Reid Kleckner <rnk at google.com> wrote:
> LGTM, but you should get an OK from Chandler since this was basically his
> idea.
>
> On Tue, Jul 23, 2013 at 5:58 PM, Hans Wennborg <hans at chromium.org> wrote:
>>
>> On Tue, Jul 23, 2013 at 10:56 AM, Reid Kleckner <rnk at google.com> wrote:
>> > I think we want to have a whitelist of "clang options" that are distinct
>> > from gcc options, rather than blacklisting a troublesome few (-MD) as
>> > GCCOptions.  That seemed to be the main conclusion of the discussion on
>> > cfe-dev.
>>
>> I thought for a while that blacklisting "a troublesome few" would make
>> for a much shorter list than whitelisting "clang options", but now
>> that I look at the file again, I see that there's a very large amount
>> of options that don't apply to clang-cl, and lots of conflicts too.
>
>
>> I've attached a new patch that does the whitelist approach, and starts
>> with a pretty short whitelist. I figure we can add more stuff too it
>> as needed.
>
>
> I agree, I think the risk of exposing too much is greater than the risk of
> exposing too little, in which case we just add it and the user can work
> around it with -Xclang.

http://llvm-reviews.chandlerc.com/D1215

Files:
  include/clang/Driver/Options.h
  include/clang/Driver/Options.td
  lib/Driver/Driver.cpp
  test/Driver/cl.c
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D1215.1.patch
Type: text/x-patch
Size: 18126 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130724/cd24f735/attachment.bin>


More information about the cfe-commits mailing list