[PATCH] cpp11-migrate: Write header replacements to disk
Guillaume Papin
guillaume.papin at epitech.eu
Wed Jul 24 10:23:45 PDT 2013
================
Comment at: test/cpp11-migrate/HeaderReplacements/common.h:4
@@ +3,3 @@
+
+#include <vector>
+
----------------
Tareq A. Siraj wrote:
> Guillaume Papin wrote:
> > I would suggest not using a standard include in the test, it tends to break the build on some platform.
> Will change in the updated patch. Just curious, can you give me an example when this might break? I am assuming the tests are run on the same machine llvm+clang is built and they use the STL extensively.
The hexagone and Windows buildbots have different (no) headers.
Here is an example for hexagone that I got a few days ago: http://lab.llvm.org:8011/builders/clang-hexagon-elf/builds/522/steps/check-all/logs/Clang%20Tools%3A%3AReformatting.cpp
IIRC the Windows error was different, the headers were found but clang failed at parsing some wchar_t/wstring stuff.
http://llvm-reviews.chandlerc.com/D1142
BRANCH
write_replacements_to_disk
ARCANIST PROJECT
clang-tools-extra
More information about the cfe-commits
mailing list