[PATCH] Enhance PPCallbacks::Defined callback to provide SourceRange
Kim Gräsman
kim.grasman at gmail.com
Fri Jul 19 14:19:25 PDT 2013
John, Argyrios,
On Fri, Jul 19, 2013 at 8:45 PM, Thompson, John
<John_Thompson at playstation.sony.com> wrote:
>
>>It would be great if you could also add some unit tests for the recent
>> changes in unittests/Lex/PPCallbacksTest.cpp but this can be done
>> post-commit.
>
> Oh, I didn’t know about this test. Thanks for pointing it out. Will do.
I wrote PPCallbacksTest originally, and looking back at it, it's very
centered around the InclusionDirective callback. I wonder if it should
change names into PPCallbacksInclusionDirectiveTest or something?
The setup is pretty heavy for InclusionDirective, so it might prove
painful to add new, simpler PPCallbacks tests to this suite.
Just a heads-up,
- Kim
More information about the cfe-commits
mailing list