[PATCH] [ms-cxxabi] Emit linkonce complete dtors in TUs that need them

[John McCall]

On Jul 19, 2013, at 12:28 PM, Reid Kleckner <rnk at google.com> wrote:
> +  // XXX: In the Microsoft ABI, we want to emit a delegating complete dtor
> +  // without a definition, which means we won't be able to tell if the
> +  // definition is a try body.  In this case, MSVC simply delegates, so we do
> +  // the same.
> 
> What is this XXX about?  Is this a FIXME?  It looks like we're actually doing it.
> 
> I should remove that.  I'm still confused about why destructors defined as try bodies need to be a special case, but the current behavior should be compatible with cl.exe.

You can’t delegate the base construction when there’s a try body and virtual
bases because then the try body would appear twice on the stack.

John.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130719/84ca1d7e/attachment.html>