[PATCH] Add contains() and overlaps() predicates to tooling::Range.
Guillaume Papin
guillaume.papin at epitech.eu
Fri Jul 19 05:10:11 PDT 2013
If it looks good, can you commit for me? I do not have commit right.
Thanks.
================
Comment at: unittests/Tooling/RefactoringTest.cpp:336
@@ +335,3 @@
+TEST(Range, overlaps) {
+ EXPECT_TRUE(Range(10, 10).overlaps(Range(0, 11)));
+ EXPECT_TRUE(Range(0, 11).overlaps(Range(10, 10)));
----------------
Manuel Klimek wrote:
> Now that I see that test, can we call it overlapsWith (or is that already correct English? - non-native-speaker here ;)
non-native-speaker as well, but overlapsWith() sounds better, I renamed it.
http://llvm-reviews.chandlerc.com/D1184
BRANCH
range-predicates
ARCANIST PROJECT
clang
More information about the cfe-commits
mailing list