[PATCH] [ms-cxxabi] Emit linkonce complete dtors in TUs that need them
Reid Kleckner
rnk at google.com
Wed Jul 17 06:37:43 PDT 2013
================
Comment at: lib/CodeGen/CGCXX.cpp:289
@@ +288,3 @@
+ dtorType == Dtor_Complete && dtor->getParent()->getNumVBases() == 0)
+ dtorType = Dtor_Base;
+
----------------
Timur Iskhodzhanov wrote:
> Hm, am I right that Dtor_Complete and Dtor_Base should have different fnType in the Microsoft ABI ?
I'm pretty sure they're always identical, even with virtual bases. They should both be "void (this)". For Itanium, the base structors take a VTT parameter and the complete structor does not. In the Microsoft ABI, they use vtordisps in some way that we haven't implemented yet.
http://llvm-reviews.chandlerc.com/D1066
More information about the cfe-commits
mailing list