[PATCH] [Driver] Convert response files with UTF-16 BOMs to UTF-8
Reid Kleckner
rnk at google.com
Mon Jul 15 05:37:49 PDT 2013
> Is it possible for the buffer to only contain a single byte?
MemoryBuffer makes sure the file is null terminated, but the empty file is
still a corner case where we have a single byte buffer over read. I should
fix it.
This is growing enough corner cases that I'm reconsidering my decision to
not put this in llvm/lib/Support/ConvertUTF8Wrappers.cc. I didn't like the
idea of loading an entire response file (usually large) into a std::string,
but the reality is that we're building a set of strings anyway.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130715/e219854e/attachment.html>
More information about the cfe-commits
mailing list