[PATCH] Microsoft C++ Record Layout

Eli Friedman eli.friedman at gmail.com
Fri Jul 12 13:50:17 PDT 2013


On Fri, Jul 12, 2013 at 1:00 PM, Warren Hunt <whunt at google.com> wrote:
>
>   To replay about the changes to ms_class_layout.  It's a bit odd to talk about DataSize in MS land because DataSize is a term defined in the Itanium layout algorithm and doesn't necessary apply.  I did what I think it most similar.  The Itanium ABI does not modify dsize after laying out fields so virtual bases aren't included.  The existing tests assert that size and dsize should be the same in these tests but that is clearly wrong given that these classes have virtual bases, so the non-virtual size and data size should be smaller than the size.
>
> http://llvm-reviews.chandlerc.com/D1026

Okay, that makes sense.

-Eli




More information about the cfe-commits mailing list